Find another location where get_ikind results in an error #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixKrayer
previously approved these changes
Jul 18, 2022
|
Do you want to add the svcomp test? I personally do not think it's really necessary here |
Dudeldu
force-pushed
the
fix-ikind-issue-in-cast-check
branch
from
2dc8cc7
to
4f241da
Compare
Dudeldu
force-pushed
the
fix-ikind-issue-in-cast-check
branch
from
4f241da
to
ff56a9e
Compare
FelixKrayer
approved these changes
Jul 19, 2022
|
I trust, you know what you are doing with the safeness of casts from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rare cases (sv-comp:
floats-cbmc-regression/float21.yml) the check onis_safe_castthrows an exception due to a call toget_ikindon potentially float arguments insideIntDomain.Size.is_cast_injective. Now we directly ignore all casts that have a float-like part.